[
https://issues.apache.org/jira/browse/HADOOP-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638507#action_12638507
]
Hadoop QA commented on HADOOP-4380:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391848/h4380.patch
against trunk revision 703320.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3437/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3437/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3437/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3437/console
This message is automatically generated.
> Make new classes in mapred package private instead of public
> ------------------------------------------------------------
>
> Key: HADOOP-4380
> URL: https://issues.apache.org/jira/browse/HADOOP-4380
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: h4380.patch
>
>
> I think we should make the following new mapred classes package private:
> Child
> JVMId
> JobTrackerInstrumentation
> QueueManager
> ResourceEstimator
> SkipBadRecords
> TaskTrackerInstrumentation
> TaskTrackerMetricsInst
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
