[ 
https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638708#action_12638708
 ] 

Brian Bockelman commented on HADOOP-3422:
-----------------------------------------

Hey stack,

1) I didn't add the log statements because I don't know the "preferred" way to 
add a logger to classes for this project.  I hoped someone who knew would come 
along and help out.
2) I don't know the logic behind the ThreadLocal StringBuffer stuff.  Adoption 
from the original patch.
3) The update to the patch which maps Long to float is bust.  The class doesn't 
have a way to serialize floats with XDR, so I'm not sure what would happen.

For now, use the original, not the updated patch - having the buffer overflow 
is better than nothing at all with floats.

> Ganglia counter metrics are all reported with the metric name "value", so the 
> counter values can not be seen
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3422
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.1
>            Reporter: Jason
>         Attachments: diff-20080520-1025.txt, 
> ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The JobInProgress class reports all metrics with the name "value". The 
> FileMetrics class puts all of the tags into the name when reporting the 
> individual values, but the Ganglia Context does not put the tags into the 
> name..
> This patch modifies the context to build names for the counter metrics out of 
> the tag values. This enables the user to see the indivdual counter values 
> with the ganglia web tool, on a per job basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to