[ 
https://issues.apache.org/jira/browse/HADOOP-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639140#action_12639140
 ] 

Hemanth Yamijala commented on HADOOP-4373:
------------------------------------------

I incorporated the first two comments. 

The last one I've not done. One reason is that a check for capacity percentages 
is already done in HADOOP-4178 which is committed to trunk. Unfortunately, it 
does not check for zero capacities. Hence two patches will need to be generated 
to handle this - one for Hadoop 0.19, and one for trunk. Since it is only error 
handling, I am thinking it is not worth that much effort.

The second is, specifying a value of zero for guaranteed capacity, along with 
this patch, I think makes a nice way to disable a queue. Arguably, this is 
better done by explicitly having a configuration parameter for enabling / 
disabling a queue. But until that comes, I am thinking this is a nice side 
effect to have.

> Guaranteed Capacity calculation is not calculated correctly
> -----------------------------------------------------------
>
>                 Key: HADOOP-4373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4373
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Hemanth Yamijala
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4373.patch, HADOOP-4373.patch, HADOOP-4373.patch
>
>
> Guaranteed Capacity calculation is not calculated correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to