[
https://issues.apache.org/jira/browse/HADOOP-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640933#action_12640933
]
Hemanth Yamijala commented on HADOOP-4149:
------------------------------------------
Looks good overall.
Few minor comments:
- I think {{STARTTIME_JOB_COMPARATOR}} in {{JobQueuesManager}} should also
compare Job IDs if start times are the same. This will handle a corner case
where start times are somehow the same.
- I think the tests (in both TestJobInProgressListener and
TestCapacityScheduler) can be a little simpler:
-- Submit two jobs and verify their order
-- Change the priority of the first to be lower, and verify the order is
reversed.
-- Change the start time of the first, and verify the order is reversed again.
- In TestCapacityScheduler, the initialization should be done for the job which
is in the front of the waiting queue.
- It should also verify that when completed, the job is not present in the
running queue, instead of the waiting queue.
Please post results of test-patch and ant test after these changes are made.
> JobQueueJobInProgressListener.jobUpdated() might not work as expected
> ---------------------------------------------------------------------
>
> Key: HADOOP-4149
> URL: https://issues.apache.org/jira/browse/HADOOP-4149
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4149-v1.5.patch
>
>
> {{JobQueueJobInProgressListener}} uses a {{TreeSet}} to store the sorted
> collection of {{JobInProgress}} objects. The comparator used to sort the JIPs
> follow the following order
> - priority (>=)
> - start time (<=)
> - job id [jt-identifier, job-index] (<=)
> If any JIP object is changed w.r.t priority or start-time, then the TreeSet
> will be inconsistent. Hence doing a delete might not work. Consider the
> following
> 1) jobs are submitted in the following order
> ||number||jobid||priority||
> |1|j1|NORMAL|
> |2|j2|LOW|
> |3|j3|NORMAL|
> 2) The sorted collection will be in the order : {{j1,j3,j2}}
> 3) If job3's priority is changed to LOW then the collection wont change but
> delete will bail out on j1 itself as the comparator will return a -ve number.
> TreeSet uses the comparator both for sorting and deleting. If i indicates
> the index in the collection and obj represents the object under
> consideration, then looks like TreeSet.remove(obj) follows something like :
> - continue to search if the compare(i, obj) is -ve
> - bail out if the compare(i, obj) is +ve
> - delete the obj of compare(i,obj) == 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
