[ https://issues.apache.org/jira/browse/HADOOP-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644465#action_12644465 ]
Konstantin Shvachko commented on HADOOP-3461: --------------------------------------------- We have a time/space tradeoff here. Using Strings eliminates conversions to/from StringBytesWritable, but it also increases the size of INodeFileUnderConstruction since String uses 2 bytes per character instead of 1. I think it is right to resolve it in favor of time because the number of files under construction is small relative to the total number of files. +1 > Remove dfs.StringBytesWritbale > ------------------------------ > > Key: HADOOP-3461 > URL: https://issues.apache.org/jira/browse/HADOOP-3461 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: 3461_20081030.patch > > > In dfs, some classes, such as INodeFileUnderConstruction use, > StringBytesWritbale as member type. The values are converted from String to > StringBytesWritbale in setter and converted back to String in getter. These > overhead is unnecessary. > StringBytesWritbale is not used in RPC nor dfs image. No version change will > be introduced. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.