[
https://issues.apache.org/jira/browse/HADOOP-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645124#action_12645124
]
Sanjay Radia commented on HADOOP-4044:
--------------------------------------
Went though the patch. Looks good.
Feedback:
1) Why does createSymLink create the group name as "none" rather than pass a
null parameter to use the
group name from the parent dir similar to the create and mkdir operations.
2) rename and createSymlink both take two path parameters - either of the paths
can traverse a symlink.
createSymlink does not handle this while rename does.
An alternate way to handle this (compared to how rename does) is to have the
FsResult return a flag saying which of the two paths cross a symlink.
3) getFileInode throws UnresolvedPathException. However,
LeaseManager:findPath() was changed to
throw IOException (it threw no exceptions before). findPath should be declared
to throw only the UnresolvedPathException.
4) There is a test to check that symlinks are correctly persisted in
fsimage/editslogs.
Please add TestSymlinks that tests for symlinks for each of FileSystem methods
that take one or more path names. For those that take multiple path names, the
test should test for symlinks in either parameter.
> Create symbolic links in HDFS
> -----------------------------
>
> Key: HADOOP-4044
> URL: https://issues.apache.org/jira/browse/HADOOP-4044
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: 4044_20081030spi.java, HADOOP-4044-strawman.patch,
> symLink1.patch, symLink1.patch, symLink11.patch, symLink4.patch,
> symLink5.patch, symLink6.patch, symLink8.patch, symLink9.patch
>
>
> HDFS should support symbolic links. A symbolic link is a special type of file
> that contains a reference to another file or directory in the form of an
> absolute or relative path and that affects pathname resolution. Programs
> which read or write to files named by a symbolic link will behave as if
> operating directly on the target file. However, archiving utilities can
> handle symbolic links specially and manipulate them directly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
