[ 
https://issues.apache.org/jira/browse/HADOOP-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646024#action_12646024
 ] 

Hadoop QA commented on HADOOP-4618:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393549/MoveHttpServer.patch
  against trunk revision 712344.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3558/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3558/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3558/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3558/console

This message is automatically generated.

> Move http server from FSNamesystem into NameNode.
> -------------------------------------------------
>
>                 Key: HADOOP-4618
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4618
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.1.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.20.0
>
>         Attachments: MoveHttpServer.patch, MoveHttpServer.patch
>
>
> NameNode is responsible now for starting its RPC server. The (web UI) http 
> server is started inside FSNamesystem class.
> I think it should be the NameNode's responsibility to deal with all issues 
> intended for exposing information it holds to the outside world. This should 
> include the RCP server as well as the http server.
> And FSNamesystem class should be a logical container of internal namespace 
> data-structures and in general should not be accessed directly from the 
> outside.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to