[ https://issues.apache.org/jira/browse/HADOOP-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646047#action_12646047 ]
Hadoop QA commented on HADOOP-4589: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12393548/4589_20081107.patch against trunk revision 712344. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3561/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3561/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3561/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3561/console This message is automatically generated. > Fix the PiEstimator output messages and code comments > ----------------------------------------------------- > > Key: HADOOP-4589 > URL: https://issues.apache.org/jira/browse/HADOOP-4589 > Project: Hadoop Core > Issue Type: Bug > Components: documentation, examples > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Priority: Minor > Attachments: 4589_20081106.patch, 4589_20081107.patch > > > There are bugs in the PiEstimator output messages and the code comments are > insufficient for beginners learning map/reduce programs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.