[ 
https://issues.apache.org/jira/browse/HADOOP-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650866#action_12650866
 ] 

Amareshwari Sriramadasu commented on HADOOP-4623:
-------------------------------------------------

Changes in JobInProgress look good.
In TestJobInProgress, instead of directly accessing JIP.runningMapTasks, 
JIP.runningMapTasks variables, you can use public methods runningMaps() and 
runningReduces().
I don't know whether UtilsForTest refactoring is needed in this jira, but the 
code changes look fine.

> Running tasks are not maintained by JobInProgress if speculation is off
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4623
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4623
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Amar Kamat
>            Assignee: Amar Kamat
>         Attachments: HADOOP-4623-v1.1.patch, HADOOP-4623-v1.2.patch
>
>
> {{JobInProgress}} doesnt maintain any structure for running tasks if 
> speculation is turned _off_.  {{getRunningMapCache()}} in {{JobInProgress}} 
> exposes the running map cache. This api returns an empty {{Map}} if 
> speculation turned off. 
> _Usage_ :
> {{CapicityScheduler}} requires a list of running tasks for both speculated 
> and non-speculated jobs. See HADOOP-4558 to see how this issue affects 
> {{CapacityScheduler}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to