[ 
https://issues.apache.org/jira/browse/HADOOP-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653097#action_12653097
 ] 

Chris Douglas commented on HADOOP-4758:
---------------------------------------

{noformat}
     [exec] -1 overall.

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.

     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.
{noformat}

There are no unit tests for metrics.

> Add a splitter for metrics contexts
> -----------------------------------
>
>                 Key: HADOOP-4758
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4758
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: 4758-0.patch
>
>
> It is currently not possible to configure multiple metrics contexts. It would 
> be helpful if one could support more than one type of collector.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to