[ 
https://issues.apache.org/jira/browse/HADOOP-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653686#action_12653686
 ] 

Amar Kamat commented on HADOOP-4445:
------------------------------------

Few comments :
{{TestCapacityScheduler}}
1) 
{code}
-    String[] infoStrings = schedulingInfo.split("\n");
-    
+    String[] infoStrings = schedulingInfo.split("\n");  
{code}
Unnecessary diff.

2) I feel we should break {{testSchedulingInformation()}} into 3 sub testcases 
namely
- {{testQueueSchedulingInformation()}}
- {{testRunningSchedulingInformation()}}
- {{testWaitingSchedulingInformation()}}
etc .... or something like that. The reason being any small change might 
require understanding the complete test case and also making/adjusting changes 
to support the complete testcase as a whole.

> Wrong number of running map/reduce tasks are displayed in queue information.
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-4445
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4445
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>         Environment: Hadoop r705159, Queue=default, GC=100% 
> MapCapacity=ReduceCapacity=212
>            Reporter: Karam Singh
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: HADOOP-4445-1.patch
>
>
> Wrong number of running map/reduce tasks are displayed in queue information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to