[ 
https://issues.apache.org/jira/browse/HADOOP-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654320#action_12654320
 ] 

Hadoop QA commented on HADOOP-4753:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12395239/4753-1.patch
  against trunk revision 724229.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/console

This message is automatically generated.

> gridmix2 code can be condensed
> ------------------------------
>
>                 Key: HADOOP-4753
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4753
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: benchmarks
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: 4753-0.patch, 4753-1.patch
>
>
> The gridmix2 benchmark code, particularly GridMixRunner, contains a lot of 
> duplication that can be condensed into a more manageable state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to