[
https://issues.apache.org/jira/browse/HADOOP-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654660#action_12654660
]
Jakob Homan commented on HADOOP-4757:
-------------------------------------
Alex-
I've looked at the patch and have a few questions.
* For the DRFA and TLA appenders, shouldn't it be ConversionPattern rather
than ConversationPattern?
* There are several appenders included in the default log4j.properites that
are not enabled by default (c.f. RFA), which are not included in the log4j.xml.
To minimize issues with users who may be enabling and using them, should these
be converted as well?
* Does the xml format support value substitution to override defaults? For
example, how would "./hadoop.log" in the file param on the DRFA be substituted?
Currently it's handled by substitution, but I'm not sure how this would work
with the xml file. Is it possible to define these default values in the xml?
* There are a few params from the original file that don't look like they
made it into the new one, such as the tasklog noKeepSplits, purgeLogSplits and
logsRetainsHours. Should these be included as well?
* Does the build.xml file need to be modified to remove the reference to the
log4j.properties and a new one to log4j.xml be inserted?
> Replace log4j.properties with log4j.xml
> ---------------------------------------
>
> Key: HADOOP-4757
> URL: https://issues.apache.org/jira/browse/HADOOP-4757
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Alex Loddengaard
> Assignee: Alex Loddengaard
> Priority: Minor
> Attachments: log4j_xml_config.patch, log4j_xml_config_v2.patch
>
>
> Certain log4j features are not configurable via the log4j.properties file,
> not to mention the log4j.properties file is messy. For this reason, we
> should transition to a XML file to configure log4j. The .properties vs. .xml
> argument has only come up in HADOOP-211, where the XML configuration was
> vetoed for Tomcat integration issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
