[ 
https://issues.apache.org/jira/browse/HADOOP-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655006#action_12655006
 ] 

Konstantin Shvachko commented on HADOOP-4795:
---------------------------------------------

+1.
If the code in internalReleaseLease() below the new IOExceptions you introduced 
would throw an exception the data-structures may become inconsistent. But as I 
can see these exceptions are not thrown anywhere below under the conditions. We 
should commit this.
Another concern that existing images will contain FileUnderConstruction, which 
will unclosable forever, and therefore we should investigate how to convert 
them into real files in a separate jira.

> Lease monitor may get into an infinite loop
> -------------------------------------------
>
>                 Key: HADOOP-4795
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4795
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.3
>
>         Attachments: 4795_20081205.patch, 4795_20081208.patch, 
> 4795_20081209.patch, 4795_20081209_0.18.patch, TestLeaseMonitor.java
>
>
> If a lease is not found in the namespace for some reasons (e.g. bugs), lease 
> monitor may get into an infinite loop.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to