[
https://issues.apache.org/jira/browse/HADOOP-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655549#action_12655549
]
Hadoop QA commented on HADOOP-4365:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395566/hadoop-4365.patch
against trunk revision 725547.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3705/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3705/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3705/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3705/console
This message is automatically generated.
> Configuration.getProps() should be made protected for ease of overriding
> ------------------------------------------------------------------------
>
> Key: HADOOP-4365
> URL: https://issues.apache.org/jira/browse/HADOOP-4365
> Project: Hadoop Core
> Issue Type: Improvement
> Components: conf
> Affects Versions: 0.20.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: hadoop-4365.patch
>
>
> HADOOP-4293 does make Configuration cleaner and easier to work with, but it
> does contain assumptions about how configurations are represented (in a
> private Properties instance) that subclasses may wish to diverge from.
> By making getProps() protected, people who subclass JobConf or Configuration
> can do their own binding from configuration data to Properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
