[
https://issues.apache.org/jira/browse/HADOOP-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657287#action_12657287
]
Hemanth Yamijala commented on HADOOP-4782:
------------------------------------------
Peeyush, few comments:
- We should remove the umask change that we did in HADOOP-4705. Without that,
we are still opening up the directories more than required. Please remember to
remove the comment we made around the umask call in code.
- The methods createJTHistoryDir and setJTHistoryDirPermission should be
private. By convention, rename them as __createJTHistoryDir and
__setJTHistoryDirPermission.
- jobtrackerhistorydir does not seem to be needed as a class variable. It is
only used in the two new methods you introduced.
- Python documentation comments are usually mentioned with ''' (three single
quotes) rather than a double quote.
When testing this patch, can you please make sure that the directory
permissions are set to ONLY 710 for the directories upto the history directory,
and 700 for everything else (non-JobTracker objects).
> [HOD] HOD opens up directory permissions more than required
> -----------------------------------------------------------
>
> Key: HADOOP-4782
> URL: https://issues.apache.org/jira/browse/HADOOP-4782
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/hod
> Affects Versions: 0.20.0
> Reporter: Hemanth Yamijala
> Assignee: Peeyush Bishnoi
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: hadoop-4782.txt
>
>
> In HADOOP-4705, we fixed hod to grant read access to all directories and
> files that HOD creates, and also set the umask such that files created by
> Hadoop also get read permissions to world. In shared clusters, this is
> opening up too much to the users. This issue is for resetting the permissions
> to be as constrained as possible, while still addressing the requirement
> raised in HADOOP-4705.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
