[
https://issues.apache.org/jira/browse/HADOOP-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657603#action_12657603
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4895:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
No new tests added since this only removed deprecated codes.
Tested locally. TestMapReduceLocal failed but it is not related to this. See
HADOOP-4907.
> Remove deprecated methods in DFSClient
> --------------------------------------
>
> Key: HADOOP-4895
> URL: https://issues.apache.org/jira/browse/HADOOP-4895
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4895_20081216.patch
>
>
> The following two deprecated methods in DFSClient should be removed:
> - getHints(String src, long start, long length) throws IOException
> - isDirectory(String src) throws IOException
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
