[
https://issues.apache.org/jira/browse/HADOOP-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658276#action_12658276
]
Owen O'Malley commented on HADOOP-4909:
---------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
There are no functional changes in this patch to test.
> Clean up map/reduce api to take JobContext in the static methods
> ----------------------------------------------------------------
>
> Key: HADOOP-4909
> URL: https://issues.apache.org/jira/browse/HADOOP-4909
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.20.0
>
> Attachments: h4909.patch, h4909.patch
>
>
> Several of the static methods in the HADOOP-1230 api aren't consistent in
> that the setters take Job objects and the getters take Configuration objects.
> It would be better if the getters took JobContext objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
