[
https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659456#action_12659456
]
gkesavan edited comment on HADOOP-4948 at 12/28/08 11:17 AM:
-----------------------------------------------------------------------
I'm able to reproduce the failure.
After the the fix for HADOOP-4920, the package target depends on docs target,
with inturn depends on forrest.home and java5.home
When we call the test-patch target through ant though, we pass the forrest.home
& java5.home the test-patch.sh
script doesn't seem to pass the 2 env variables while calling the tar and
findbugs target, which is causing the ant test-pach failure.
This patch *HADOOP-4849.patch cannot be tested, as it modifies the
test-patch.sh itself.*
This patch is tested manually , here is the test-patch result:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Thanks,
Giri
was (Author: gkesavan):
I'm able to reproduce the failure.
After the the fix for HADOOP-4920, the package target depends on docs target,
with inturn depends on forrest.home and java5.home
When we call the test-patch target through ant though we pass the forrest.home
& java5.home the test-patch.sh script doesn't seem to pass the 2 env variables
when calling the tar and findbugs target, which is causing the ant test-pach
failure.
This patch *HADOOP-4849.patch cannot be tested, as it modifies the
test-patch.sh itself.*
this patch is tested manually , here is the test-patch result:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Thanks,
Giri
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.21.0
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch
> -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar >
> /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
