[
https://issues.apache.org/jira/browse/HADOOP-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661559#action_12661559
]
Hemanth Yamijala commented on HADOOP-4980:
------------------------------------------
Very minor nit, (and actually a bug in existing code too):
In toString of TaskSchedulingInfo, one of the values used for computing
runningTasksAsPercent and the user's running tasks percentage should be cast to
a float. Otherwise, the value gets converted to a float after the computation
happens - which does not address the original concern.
Otherwise +1 for the patch.
> Cleanup the Capacity Scheduler code
> -----------------------------------
>
> Key: HADOOP-4980
> URL: https://issues.apache.org/jira/browse/HADOOP-4980
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/capacity-sched
> Reporter: Vivek Ratan
> Attachments: 4980.1.patch, 4980.2.patch, 4980.3.patch
>
>
> Given the number of changes that have been made by different folks to the
> Capacity Scheduler code, the code needs to be cleaned up. Some comments and
> variable names are misleading, and the core logic is not in a central place,
> making it harder to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
