[
https://issues.apache.org/jira/browse/HADOOP-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663045#action_12663045
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4985:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
{noformat}
No new tests added since there are only declaration changes but no code logic
change.
> IOException is abused in FSDirectory
> ------------------------------------
>
> Key: HADOOP-4985
> URL: https://issues.apache.org/jira/browse/HADOOP-4985
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4985_20090106.patch, 4985_20090107.patch,
> 4985_20090109.patch
>
>
> In FSDirectory, quite a few methods are unnecessary declared with "throws
> IOException". In some cases, it can just be removed without causing any
> compilation problem. In some other cases, it can be replaced with a specific
> subclass like QuotaExceededException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
