[
https://issues.apache.org/jira/browse/HADOOP-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663334#action_12663334
]
Steve Loughran commented on HADOOP-4965:
----------------------------------------
You shouldn't need to call {{StringUtils.stringifyException()}}, because
passing it down to the log tools as is lets your logging tool handle the
chained strack trace themselves -which can include a more structured output
than the {{stringifyException()}} call. I'd prefer something like:
{{LOG.error("Exception closing file " + src + ": " +ie,ie);}}
> DFSClient should log instead of printing into std err.
> ------------------------------------------------------
>
> Key: HADOOP-4965
> URL: https://issues.apache.org/jira/browse/HADOOP-4965
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: DFSClientLogging.patch, DFSClientLogging.patch
>
>
> {{DFSClient.LeaseChecker.close()}} uses {{System.err.println()}} and
> {{Exception.printStackTrace()}} to output the exception.{{LOG.error()}}
> should be used instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
