[ 
https://issues.apache.org/jira/browse/HADOOP-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663976#action_12663976
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5017:
------------------------------------------------

I forgot to post the ant test results.  Here it is:
{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 44 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.
{noformat}
I also tested the patch locally.  Everything passed except the problem reported 
in HADOOP-4907.

> NameNode.namesystem should be private
> -------------------------------------
>
>                 Key: HADOOP-5017
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5017
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5017_20090112.patch, 5017_20090114.patch
>
>
> As stated in the comment:
> {code}
>   public FSNamesystem namesystem; // TODO: This should private. Use 
> getNamesystem() instead. 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to