[
https://issues.apache.org/jira/browse/HADOOP-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663997#action_12663997
]
Sreekanth Ramakrishnan commented on HADOOP-4831:
------------------------------------------------
Looking good few minor issues:
* In TestJobInitalization method testJobInitInSingleQ() why don't we just exit
if one of the test cases fail i.e. normalPriorityJobInitializationTest,
highPriorityJobInitializationTest and jobKillWhileSetupIsRunning are the test
any one of the tailure should stop the subsequent test cases from running right?
* In testJobsInitInMultipleQs(), the property
_mapred.capacity-scheduler.init-worker-threads_ is a global property does not
need to be set in the loop.
* Rename testJobInitInSingleQ() - testJobInitInSingleQueue()
* Rename testJobsInitInMultipleQs() - testJobsInitInMultipleQueues()
Minor nits: diff's contains an unnecessary blank line in
ClusterWithCapacityScheduler file.
> Have end to end tests based on MiniMRCluster to verify the correct behaviour
> of job initialization.
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4831
> URL: https://issues.apache.org/jira/browse/HADOOP-4831
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Vinod K V
> Assignee: Vinod K V
> Attachments: HADOOP-4831-20081230-git-final.txt,
> HADOOP-4831-20090107-svn-1.txt, HADOOP-4831-20090113-git.txt
>
>
> Write tests to verify that the right number of jobs in the right order are
> initialized and that the limits on the number of jobs that can stay
> initialized at any time are honoured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
