[
https://issues.apache.org/jira/browse/HADOOP-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664045#action_12664045
]
Ari Rabkin commented on HADOOP-5042:
------------------------------------
Couple things I'm nervous about.
1) This patch introduces @author tags. This conflicts with Hadoop coding
standards. Is there a reason for adding them?
2) You do a lexical sort to figure out which rotated files are old. Is this
safe in context?
3) It's sort of icky to repeatedly remove the first element from an array --
the remove is O(N) each time. That''s probably okay here, since the array
never gets big and we don't run this very often. But it might be nice to leave
a comment explaining why this is okay.
4) This might not bother us, but there's a little bit of a
security/correctness issue here: The pattern can easily match files that don't
contain $fileName -- just do something like "$filename | .*". And we don't
check for that. A fix would be to first match against .*$filename.* before
applying the user's regex.
> Add expiration handling to the chukwa log4j appender
> -----------------------------------------------------
>
> Key: HADOOP-5042
> URL: https://issues.apache.org/jira/browse/HADOOP-5042
> Project: Hadoop Core
> Issue Type: New Feature
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-5042.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
