[
https://issues.apache.org/jira/browse/HADOOP-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665321#action_12665321
]
Hemanth Yamijala commented on HADOOP-5048:
------------------------------------------
bq. The comments indicate what the logic is like, the code may implement it
differently.
Vivek, if by this statement you mean that you want to give a gist of the
algorithm, that's fine. But the way it is commented right now, it does look
like the actual code (declaring variables etc) and is very verbose. Given such
a level of verbosity, I started looking at code that matches the comments. I
guess there are others who would do so too. Also, when one wants to change code
in this area, they would look at the comments and the code, both. If they don't
match, IMHO, it will confuse more than clarify, even if only the implementation
has changed.
If you feel the inline comments that go with the code will not be good enough,
I would recommend we give a gist of the algorithm that explains things. That
way, we don't have to change it for every line or branch we touch as long as
the summary remains the same. And it would be more explanatory as you would
like.
> Sometimes job is still displayed in jobqueue_details page for long time after
> job was killed.
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-5048
> URL: https://issues.apache.org/jira/browse/HADOOP-5048
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Karam Singh
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5048-1.patch, HADOOP-5048-2.patch
>
>
> When I tried kill all running job, I noticed that were two jobs were listed
> on jobqueue_details.jsp page page as well as they were also listed under
> failed job on jobtracker.jsp page.
> When I checked status of each that was displayed "killed" and Cleanup task
> status as "Successful", but both jobs were also being on jobqueue_details.jsp
> page for longtime e.g up to 10 -15 mins after I restarted JobTracker.
> Before killing the jobs, status of both jobs was running and no task of from
> them was scheduled.
> I noticed this behavior on 3 different occasions. But is this random, not
> always reproducible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
