[ 
https://issues.apache.org/jira/browse/HADOOP-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665714#action_12665714
 ] 

dhruba borthakur commented on HADOOP-5075:
------------------------------------------

One option would be to log something when the "break" exited early, if that 
case ever occurs. This will ensure that production systems do not get impacted 
by an infinite loop, at the same time inspecting the log will tell us that the 
software is not running optimally.

> Potential infinite loop in updateMinSlots
> -----------------------------------------
>
>                 Key: HADOOP-5075
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5075
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/fair-share
>            Reporter: Matei Zaharia
>            Priority: Blocker
>             Fix For: 0.19.1, 0.20.0, 0.21.0
>
>         Attachments: hadoop-5075-v2.patch, hadoop-5075-v3.patch, 
> hadoop-5075.patch
>
>
> We ran into a problem at Facebook where the updateMinSlots loop in the 
> scheduler was repeating infinitely. This might happen if, due to rounding, we 
> are unable to assign the last few slots in a pool. This patch adds a break 
> statement to ensure that the loop exists if it hasn't managed to assign any 
> slots.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to