[ 
https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667890#action_12667890
 ] 

Konstantin Shvachko commented on HADOOP-5097:
---------------------------------------------

# Remove comment in FSNamesystem
/** NameNode RPC address */
# I do not very much like that you add JspHelper as a NameNode members. I 
understand the intention is not to instantiate objects on the web UI, but may 
be we should rather consider making most of the methods / fields of JspHelper 
static instead of constructing the object. In any case it is better not to 
introduce helper variables in NamNode and DataNode.


> Remove static variable JspHelper.fsn
> ------------------------------------
>
>                 Key: HADOOP-5097
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5097
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>         Attachments: 5097_20090121.patch, 5097_20090126.patch
>
>
> There is another static FSNamesystem variable, fsn, declared in JspHelper.  
> We should remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to