Unreachable code in TaskInProgress.inCompleteSubTask
----------------------------------------------------
Key: HADOOP-5236
URL: https://issues.apache.org/jira/browse/HADOOP-5236
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
Priority: Minor
Fix For: 0.21.0
TaskInProgress.incompleteSubTask has the following unreachable-code :
{noformat}
if (taskState != TaskStatus.State.FAILED &&
taskState != TaskStatus.State.KILLED &&
taskState != TaskStatus.State.FAILED_UNCLEAN &&
taskState != TaskStatus.State.KILLED_UNCLEAN) {
LOG.info("Task '" + taskid + "' running on '" + trackerName +
"' in state: '" + taskState + "' being failed!");
status.setRunState(TaskStatus.State.FAILED);
taskState = TaskStatus.State.FAILED;
}
{noformat}
It would never reach this code, because it is never called from other places,
where taskState is not FAILED, KILLED, FAILED_UNCLEAN and KILLED_UNCLEAN.
Also status != null is not required, since status is never null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
