[
https://issues.apache.org/jira/browse/HADOOP-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673167#action_12673167
]
Sreekanth Ramakrishnan commented on HADOOP-5020:
------------------------------------------------
I took a quick look at the patch attached. Following are comments which I had
* We are setting username in job status in this patch which was previous not
set, I think we should change the JIRA description to reflect change which is
being bought by this patch.
* Test case {{testJobStatus()}}, shuts down the cluster bought up by
{{TestCase.setup}} method and starts a new cluster, we should avoid this in
order to save running time.
* There is a change in JobTracker, which I think is not required for this patch.
* As far as we are testing all fields in {{JobStatus}} why don't we do a sanity
check on {{JobStatus.getFinishTime()}} once we finish a job.
* We are waiting for all {{TaskTracker}} to register with {{JobTracker}} in
test case, I think this should be moved from the test case to {{MiniMRCluster}}
instead of placing it within the test.
* Finally, a suggestion, we should slowly move all usage of {{UtilsForTests}}
to {{ControlledMapReduceJob}} and add functionality in it to control job setup
and cleanup so that it can be used for testing. I think we should discuss that
in seperate JIRA.
> JobStatus of killed JobInProgress does not carry forward start time of the Job
> ------------------------------------------------------------------------------
>
> Key: HADOOP-5020
> URL: https://issues.apache.org/jira/browse/HADOOP-5020
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Sreekanth Ramakrishnan
> Assignee: Amar Kamat
> Attachments: HADOOP-5020-v1.0.patch
>
>
> If an initialized job is killed, the jobs start time is set to zero.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
