[ 
https://issues.apache.org/jira/browse/HADOOP-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673314#action_12673314
 ] 

Hadoop QA commented on HADOOP-5229:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12400113/HADOOP-5229-v1-sg.patch
  against trunk revision 744000.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3846/console

This message is automatically generated.

> duplicate variables in build.xml hadoop.version vs version let build fails at 
> assert-hadoop-jar-exists
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5229
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5229
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build
>            Reporter: Stefan Groschupf
>            Priority: Trivial
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5229-v1-sg.patch
>
>
> <property name="hadoop.jar" 
> location="${build.dir}/hadoop-${hadoop.version}-core.jar" /> where 
> hadoop.version is defined in ${ivy.dir}/libraries.properties as 
> hadoop.version=0.20.0. 
> Though <jar jarfile="${build.dir}/${final.name}-core.jar" where <property 
> name="final.name" value="${name}-${version}"/>.
> Means there is a hadoop-0.21.0-dev-core.jar builded though the 
> assert-hadoop-jar-exists target looks for a  hadoop-0.2.0-core.jar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to