[ 
https://issues.apache.org/jira/browse/HADOOP-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675522#action_12675522
 ] 

Hadoop QA commented on HADOOP-5291:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12400550/fixPidFile.patch
  against trunk revision 746274.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3888/console

This message is automatically generated.

> chukwa agent should do something sensible if CHUKWA_HOME isn't defined
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-5291
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5291
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>            Priority: Trivial
>         Attachments: fixPidFile.patch
>
>
> If Chukwa is started in such a way that CHUKWA_HOME doesn't get set, then pid 
> files are stored in chukwa/null/var....  This comes up if, e.g., the agent is 
> started within eclipse.  We can make this case look prettier by defaulting to 
> /tmp.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to