[
https://issues.apache.org/jira/browse/HADOOP-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677545#action_12677545
]
Jerome Boulon commented on HADOOP-5035:
---------------------------------------
Could you fix the indentention and put a comment on why you are doing "else if
(val >= 2000) return (val / 1000).toFixed(2) + \"x10<sup>3</sup>\";"
It's not obvious why 2000 and not 1000
Other than that the patch looks good.
> Support non Time Series charting and handle data gap more gracefully for
> Chukwa charts
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-5035
> URL: https://issues.apache.org/jira/browse/HADOOP-5035
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Environment: RedHat 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Attachments: HADOOP-5035.patch
>
>
> Chukwa charting only support time series data because the data structure is a
> HashMap of Long, Double.
> Long is the timestamp (xaxis), and Double is the yaxis value. The data
> structure will be changed to HashMap of String, Double.
> This will add capability to plot xaxis with any data.
> If the yaxis value is not a number, the charting system should skip plotting
> for this data point.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
