[
https://issues.apache.org/jira/browse/HADOOP-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678652#action_12678652
]
Vinod K V commented on HADOOP-5376:
-----------------------------------
Looked at the patch. Few comments:
- I think the correct place for the check for setup/cleanup task is
lostTaskTracker() method itself. TIP.isRunningTask() doesn't look the correct
method or atleast the correct method name.
- The original TestSetupAndCleanupFailure didn't have much javadoc, can you
add it in this patch? Particularly the TestSetupAndCleanupFailure class itself,
and the testWithDFS() method.
- We can write a test simulating the exact problem in this bug using a lost
tracker. We can have this test in the same testcase -
TestSetupAndCleanupFailure.
> JobInProgress.obtainTaskCleanupTask() throws an ArrayIndexOutOfBoundsException
> ------------------------------------------------------------------------------
>
> Key: HADOOP-5376
> URL: https://issues.apache.org/jira/browse/HADOOP-5376
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.20.0
> Reporter: Vinod K V
> Assignee: Amareshwari Sriramadasu
> Priority: Blocker
> Attachments: patch-5376.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
