[
https://issues.apache.org/jira/browse/HADOOP-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678792#action_12678792
]
Hadoop QA commented on HADOOP-5383:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401342/HADOOP-5383.patch
against trunk revision 749919.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/1/console
This message is automatically generated.
> minor : avoid building error string in verifyReplication()
> ----------------------------------------------------------
>
> Key: HADOOP-5383
> URL: https://issues.apache.org/jira/browse/HADOOP-5383
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Priority: Minor
> Attachments: HADOOP-5383.patch
>
>
> On NameNode, {{verifyReplication()}} is called for every new file created to
> check if it falls within the configured limits. Currently its implementation
> always builds the error string though it is almost never needed.
> This jira fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
