[
https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680543#action_12680543
]
Hadoop QA commented on HADOOP-5379:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401785/HADOOP-5379.patch
against trunk revision 752073.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/console
This message is automatically generated.
> Throw exception instead of writing to System.err when there is a CRC error on
> CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
