[ 
https://issues.apache.org/jira/browse/HADOOP-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680772#action_12680772
 ] 

Hadoop QA commented on HADOOP-5455:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12401859/HADOOP-5455.patch
  against trunk revision 752325.

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/console

This message is automatically generated.

> default "hadoop-metrics.properties" doesn't mention "dfs" context
> -----------------------------------------------------------------
>
>                 Key: HADOOP-5455
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5455
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: documentation, metrics
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: HADOOP-5455.patch
>
>
> The "hadoop-metrics.properties" file that's shipped in conf/ has 
> configuration settings for the metrics contexts "dfs", "mapred", and "jvm".  
> The (trivial) patch I'm proposing is to include default configuration for the 
> "rpc" context as well.  RPC metrics may be useful, and it's difficult for a 
> user to intuit otherwise that rpc metrics even exist.  (I stumbled upon them 
> after exploring with JConsole and JMX.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to