[ 
https://issues.apache.org/jira/browse/HADOOP-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680828#action_12680828
 ] 

Hemanth Yamijala commented on HADOOP-5327:
------------------------------------------

Hi, looking good. Few comments:

- I think we should not do the cleanup from the system directory in the job 
tracker restart case. Like I wrote earlier on, I think this should follow the 
same path as a job being killed. In that case, the system directory may be 
cleaned up as part of the job completion, and may be needed until then.
- Can we rename getJobDirectory to getSystemJobDir() or something similar ?
- I think we need a test case in TestQueueManager which will check that the 
system directory is being cleaned up upon unsuccessful job submission due to 
ACLs. The check for the system directory being deleted in TestRecoveryManager 
will not be needed.


> Job files for a job failing because of  ACLs are not clean from the system 
> directory
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5327
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5327
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.20.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-5327-v2.3.patch, HADOOP-5327-v2.6.patch
>
>
> Jobs which failed because of ACLs gets added during JT restart recovery 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to