[
https://issues.apache.org/jira/browse/HADOOP-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680922#action_12680922
]
Hemanth Yamijala commented on HADOOP-5395:
------------------------------------------
Looking ok. Few minor comments:
- As we are doing in HADOOP-5327, we need to delete the system directory if the
queue is invalid.
- The message seems to be printing an additional space around the queue name.
- Some formatting changes: there's a spurious space around the if condition; in
the test case, indentation is not right in the exception block.
- setupConf("mapred.queue.names","default") is confusing, because setupConf is
only for setting up ACLs. Maybe a job conf should be directly created.
- I would suggest we name the test method as something like
testSubmissionToInvalidQueue or something like that.
> When queue ACLs are enabled, the error message shown when a job is submitted
> to a non-existent queue is misleading
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5395
> URL: https://issues.apache.org/jira/browse/HADOOP-5395
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Hemanth Yamijala
> Assignee: rahul k singh
> Fix For: 0.21.0
>
> Attachments: exceptionpath
>
>
> When acls are enabled on the job tracker using the property
> mapred.acls.enabled, and a job is submitted to a queue name that does not
> exist in mapred.queue.names property, the following exception is thrown:
> org.apache.hadoop.security.AccessControlException:
> org.apache.hadoop.security.AccessControlException: User user-name cannot
> perform operation SUBMIT_JOB on queue queue-name
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:96)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:58)
>
> The message makes it appear like the queue exists, but the user does not have
> access to it, where the actual problem is that the queue does not exist at
> all.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
