[ 
https://issues.apache.org/jira/browse/HADOOP-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681833#action_12681833
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4539:
------------------------------------------------

> In general I don't also see a reason why NameNode.myMetrics should be a 
> static member.

Static variables sometimes are misused as global variables.  This is one 
example.  Another one is FSNamesystem.fsNamesystemObject (see HADOOP-2413).

BTW, could you not using the deprecated API FSNamesystem.getFSNamesystem() in 
BackupStorage?
{noformat}
+  private FSNamesystem getFSNamesystem() {
+    // HADOOP-5119 should get rid of this.
+    return FSNamesystem.getFSNamesystem();
+  }
{noformat}
I suggest passing a FSNamesystem object in the constructor BackupStorage().  
Then, pass the FSNamesystem object created in BackupNode.loadNamesystem(..), 
which is the only place creating a BackupStorage.

> Streaming Edits to a Standby Name-Node.
> ---------------------------------------
>
>                 Key: HADOOP-4539
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4539
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: BackupNode.patch, BackupNode.patch, BackupNode.patch, 
> BackupNode.patch, image001.gif, StreamEditsToBN.pdf, StreamEditsToSNN.htm
>
>
> Currently Secondary name-node acts as mere checkpointer.
> Secondary name-node should be transformed into a standby name-node (SNN). 
> The long term goal is to make it a warm standby. 
> The purpose of this issue is to provide real time streaming of edits to SNN 
> so that it contained the up-to-date namespace state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to