[ 
https://issues.apache.org/jira/browse/HADOOP-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682666#action_12682666
 ] 

Hemanth Yamijala commented on HADOOP-5516:
------------------------------------------

Regarding changes in trunk, some minor nits:

- TaskMemoryManagerThread, there is an indentation problem in one of the 
comments, which is becoming very misleading. Search for "updated state"
- Same method, the call to pTree.destroy(); was pTree.destroy(true); in trunk. 
Though this is the default value for the overloaded API, I think it is better 
to retain the original code in case it changes in future.

> TaskMemoryManagerThread crashes in a corner case
> ------------------------------------------------
>
>                 Key: HADOOP-5516
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5516
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.20.0
>            Reporter: Vinod K V
>            Assignee: Vinod K V
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: HADOOP-5516-1.txt, HADOOP-5516-trunk-1.txt
>
>
> TT's stdout says.
> {code}
> Exception in thread "org.apache.hadoop.mapred.TaskMemoryManagerThread" 
> java.lang.NullPointerException
>         at 
> org.apache.hadoop.util.ProcfsBasedProcessTree.getProcessTree(ProcfsBasedProcessTree.java:126)
>         at 
> org.apache.hadoop.mapred.TaskMemoryManagerThread.run(TaskMemoryManagerThread.java:200)
> {code}
> TaskMemoryManager crashes and no further memory management is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to