[
https://issues.apache.org/jira/browse/HADOOP-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683468#action_12683468
]
Hadoop QA commented on HADOOP-5196:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12399887/HADOOP-5196-trunk.patch
against trunk revision 755790.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/105/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/105/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/105/console
This message is automatically generated.
> avoiding unnecessary byte[] allocation in SequenceFile.CompressedBytes and
> SequenceFile.UncompressedBytes
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5196
> URL: https://issues.apache.org/jira/browse/HADOOP-5196
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.21.0
> Reporter: Hong Tang
> Assignee: Hong Tang
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5196-trunk.patch
>
>
> SequenceFile.CompressedBytes and SequenceFile.UncompressedBytes are used by
> the SequenceFile's raw bytes reading/writing API. The current implementation
> does not reuse the internal byte[] and causes unnecessary buffer allocation
> and initializaiton (zeroing the buffer).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
