[ 
https://issues.apache.org/jira/browse/HADOOP-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688516#action_12688516
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5557:
------------------------------------------------

{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
{noformat}
Ran TestOverReplicatedBlocks.  It worked fine.

> Two minor problems in TestOverReplicatedBlocks
> ----------------------------------------------
>
>                 Key: HADOOP-5557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5557
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 5557_20090323.patch
>
>
> - There is no apache license header.
> - It uses a deprecated API, FSNamesystem.getFSNamesystem().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to