[ 
https://issues.apache.org/jira/browse/HADOOP-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Klaas Bosteels updated HADOOP-5528:
-----------------------------------

    Attachment: HADOOP-5528.patch

Thanks Chris. The new patch addresses all of the issues you raised:

* The deprecated class now extends the one from mapreduce.
* Static convenience methods for setting the offsets were added.
* The indexer classes are private now (and hence also not configurable anymore).

Since the offset properties still might need to be set manually when this 
partitioner is used by a non-Java Hadoop program (e.g. a Streaming program), 
they are still documented in the javadoc for the class, but I added a paragraph 
that encourages Java programmers to use the static convenience methods instead.

Findbugs will probably complain about the the fact that the name of the 
deprecated class in mapred shadows the simple name of the class it extends, by 
the way.

> Binary partitioner
> ------------------
>
>                 Key: HADOOP-5528
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5528
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>            Reporter: Klaas Bosteels
>            Assignee: Klaas Bosteels
>         Attachments: HADOOP-5528.patch, HADOOP-5528.patch, HADOOP-5528.patch, 
> HADOOP-5528.patch
>
>
> It would be useful to have a {{BinaryPartitioner}} that partitions 
> {{BinaryComparable}} keys by hashing a configurable part of the bytes array 
> corresponding to each key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to