[ 
https://issues.apache.org/jira/browse/HADOOP-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693598#action_12693598
 ] 

Raghu Angadi commented on HADOOP-5581:
--------------------------------------

Patch looks fine. A few improvements : 

JavaDoc for getBlockLocations could be modifed to make this a part of the 
contract.
Do we need any text for FNF excepton?

Instead of adding a new test, a test simple test case could be added to another 
test (e.g. TestDistributedFIleSystem.java). That way it comes almost for free 
(see test added in HADOOP-5191). Each new test adds on the order of 7-10 
seconds, however simple it is.  


> libhdfs does not get FileNotFoundException
> ------------------------------------------
>
>                 Key: HADOOP-5581
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5581
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, libhdfs
>    Affects Versions: 0.19.1
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: HADOOP-5581.patch
>
>
> When trying to open a file that does not exist for read, libhdfs prints an 
> error out along the line of "Cannot open file <filename>".
> I believe it should be throwing the FileNotFoundException instead.  This 
> would allow us to correctly set the errno and more naturally give the errors 
> to the C-based clients.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to