[ 
https://issues.apache.org/jira/browse/HADOOP-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694359#action_12694359
 ] 

Chris Douglas commented on HADOOP-5585:
---------------------------------------

This looks good. Just two nits:
* The current patch generates a javadoc warning, and has a malformed reference 
to the non-existent method getFileSystemClasses in the docs for 
{{FileSystem::getStatistics}}
* This should have a unit test, but that can be part of a separate issue 
(possibly once HADOOP-5437 is fixed)

+1 for the functional changes

> FileSystem statistic counters are too high when JVM reuse is enabled.
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-5585
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5585
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: h5585.patch
>
>
> When JVM reuse is enabled, the FileSystem.Statistics are not cleared between 
> tasks. That means that the second task gets credit for its own reads and 
> writes as well as the first. The third gets credit for all 3 tasks reads and 
> writes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to