[
https://issues.apache.org/jira/browse/HADOOP-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695885#action_12695885
]
Hadoop QA commented on HADOOP-5494:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404671/5494-3.patch
against trunk revision 761838.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/115/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/115/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/115/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/115/console
This message is automatically generated.
> IFile.Reader should have a nextRawKey/nextRawValue
> --------------------------------------------------
>
> Key: HADOOP-5494
> URL: https://issues.apache.org/jira/browse/HADOOP-5494
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.21.0
>
> Attachments: 5494-1.patch, 5494-2.patch, 5494-3.patch
>
>
> Merger.Segment has only the next() method defined which internally calls
> next(key,value) on the underlying IFile stream. This would read both the key
> and the value bytes. It would be good to have Merger.Segment.nextRawKey(),
> that would read only the key and delay reading the value until needed (in
> Merger.MergeQueue.next()) via a new method Merger.Segment.nextRawValue().
> This would mean that we load only one value bytes at a time, and hence would
> incur potentially much less (depending on how big the values are) on the
> memory footprint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
