[ https://issues.apache.org/jira/browse/HADOOP-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698337#action_12698337 ]
dhruba borthakur commented on HADOOP-5143: ------------------------------------------ This is a good change! Can you pl merge this patch with trunk and attach a new diff file? Also, it would be nice if you can generate the patch from the base of the workspace (as described in http://wiki.apache.org/hadoop/HowToContribute). If you can add a unit test to (possibly add to TestFileCreation.java) that would be great. > Add a method to get file length for Seekable, FSDataInputStream and libhdfs > --------------------------------------------------------------------------- > > Key: HADOOP-5143 > URL: https://issues.apache.org/jira/browse/HADOOP-5143 > Project: Hadoop Core > Issue Type: New Feature > Components: dfs, fs, libhdfs > Affects Versions: 0.18.2 > Reporter: Qi Liu > Attachments: hadoop.patch > > > When open any seekable file, it should be able to get the length of the file > via Seekable interface, since the seek method should be able to detect > seeking beyond the end of file. Such interface can benefit distributed file > systems by saving a network round-trip of > FileSystem.getFileStatus(Path).getLen() for any open file. > In libhdfs, such interface should also be exposed to make native program > taking advantage of this change. > I have the changes locally for all FSInputStream concrete classes. The change > can be considered trivial, since some of the FSInputStream classes already > have a method named getFileLength(), or a member field named size/length/end. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.