[ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698984#action_12698984 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5671: ------------------------------------------------ {noformat} [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. {noformat} Tested manually, no new tests added. > DistCp.sameFile(..) should return true if src fs does not support checksum > -------------------------------------------------------------------------- > > Key: HADOOP-5671 > URL: https://issues.apache.org/jira/browse/HADOOP-5671 > Project: Hadoop Core > Issue Type: Bug > Components: tools/distcp > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: 5671_20090414.patch > > > In DistCp.sameFile(..), if src FileSystem does not support file checksum, it > should return true. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.