[
https://issues.apache.org/jira/browse/HADOOP-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699108#action_12699108
]
Sreekanth Ramakrishnan commented on HADOOP-5678:
------------------------------------------------
There has been a dependency move in gcc 4.3. The related bug in gnu is
[28080|http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28080] also,
[http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include] but I don't know if
we are currently supporting gcc 4.3 in the source.
Plus I the patch is incomplete HadoopPipes.cc also needs to be changed.
Why don't we use {{#include <cstring> #include <cstdio> #include <cstdlib>}}
instead of c style headers? We are anyway modifiying c++ source right?
> Mixed up #includes in c++ files.
> --------------------------------
>
> Key: HADOOP-5678
> URL: https://issues.apache.org/jira/browse/HADOOP-5678
> Project: Hadoop Core
> Issue Type: Bug
> Environment: Fedora 10, gcc version 4.3.2 20081105 (Red Hat 4.3.2-7)
> (GCC)
> Reporter: Ricky Zhou
> Attachments: hadoop-includes.patch
>
>
> src/c++/pipes/impl/HadoopPipes.cc, src/c++/utils/impl/SerialUtils.cc, and
> src/c++/utils/impl/StringUtils.cc fail to compile due to some mixed up
> #includes.
> When running ant -Dcompile.c++=true clean compile-c++ on svn trunk, I get
> errors about undeclared functions in the above files, such as:
> {quote}
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In
> function 'uint64_t HadoopUtils::getCurrentMillis()':
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:74: error:
> 'strerror' was not declared in this scope
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In
> function 'std::string HadoopUtils::quoteString(const std::string&, const
> char*)':
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:103:
> error: 'strchr' was not declared in this scope
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In
> function 'std::string HadoopUtils::unquoteString(const std::string&)':
> [exec]
> /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:144:
> error: 'strtol' was not declared in this scope
> {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
